Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move models to package #34154

Merged
merged 14 commits into from
Dec 27, 2024
Merged

chore: Move models to package #34154

merged 14 commits into from
Dec 27, 2024

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 10, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1356

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 10, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 36da85c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego force-pushed the move-models-to-package branch from c0fec3c to 9b8207f Compare December 10, 2024 15:03
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.37%. Comparing base (4121500) to head (36da85c).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34154      +/-   ##
===========================================
+ Coverage    59.29%   59.37%   +0.08%     
===========================================
  Files         2819     2819              
  Lines        67821    67701     -120     
  Branches     15069    15037      -32     
===========================================
- Hits         40213    40200      -13     
+ Misses       24793    24684     -109     
- Partials      2815     2817       +2
Flag Coverage Δ
unit 75.85% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34154/
on branch gh-pages at 2024-12-26 21:31 UTC

This was referenced Dec 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sampaiodiego sampaiodiego force-pushed the move-models-to-package branch from 586b75d to e8f63dd Compare December 26, 2024 14:23
@sampaiodiego sampaiodiego force-pushed the move-models-to-package branch from e8f63dd to 581224f Compare December 26, 2024 14:38
@ggazzo ggazzo marked this pull request as ready for review December 27, 2024 00:40
@ggazzo ggazzo requested review from a team as code owners December 27, 2024 00:40
@ggazzo ggazzo requested a review from a team as a code owner December 27, 2024 00:40
@ggazzo ggazzo added this to the 7.3.0 milestone Dec 27, 2024
@ggazzo ggazzo merged commit 1184b83 into develop Dec 27, 2024
18 checks passed
@ggazzo ggazzo deleted the move-models-to-package branch December 27, 2024 00:51
gabriellsh pushed a commit that referenced this pull request Dec 31, 2024
@sampaiodiego @gabriellsh
chore: Move models to package (#34154)
b0281af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaiodiego @ggazzo